I don't recall testing the Armor Scrap quest in an AV during the PvP beta test weekend, but I was browsing through some old patch notes and stumbled on this:
http://vanilla-wow.wikia.com/wiki/Patch_1.11.0
in patch 1.11.0, they incorporated a buff that is 2 minutes long to all players of the faction after completing each stage of the armor scrap quest and upgrading the troops.
"Upgrading troops through armor scrap turn-ins will also now result in your team's General enabling a periodic buff to your melee and spell damage.
◾ This buff scales from 10% at the Seasoned unit level, 20% at the Veteran unit level, and 30% at the Champion unit level. "
so this is how it should go technically:
Seasoned Units (500 armor scraps):
- Increases certain NPC efficiency (graveyard guards, mine guards and patrolling guards)
- Gives players a 10% damage and size increase buff periodically for 2 minutes (Vanndar Stormpike will yell when it is given) General's Warcry
Veteran Units (1000 armor scraps):
- Increases certain NPC efficiency further
- Gives players a 20% damage and size increase buff periodically for 2 minutes General's Warcry
Champion Units (1500 armor scraps):
- Increases NPC efficiency by the most it can be increased
- Gives players a 30% damage and size increase buff periodically for 2 minutes General's Warcry
Did anyone test if this was already implemented or the Armor Scrap quest to be scripted fully?