lua & xml

Re: lua & xml

by Renew » Sun Jan 03, 2016 1:17 pm

modernist wrote:
Renew wrote:
modernist wrote:for example, CustomNameplates is a really good example of a major addon NOT doing this and the reason i would not recommend it to people based on the code i've looked through — if i remember correctly it creates a set of 8 new "buff" frames on every tick of its OnUpdate. assuming that you're running at a consistent 60fps, thats 28800 frames being created and stacked on top of one another inside of a minute.


i dont think you can create frames onupdate without getting massiv fps dropdown...also there is only 1 event frame in whole CustomNameplates addon...


https://github.com/jejkas/CustomNamepla ... es.lua#L87
https://github.com/jejkas/CustomNamepla ... s.lua#L151

looks like there's checks before creation initialises on any textures (and it uses CreateTexture parented to the plate itself rather than more frames), so i retract my complaint. maybe i was looking at a bootleg version previously.


i had another version without all these things :P
my Addons:
- Vanilla Healing Assignments - /viewtopic.php?f=63&t=23326
- Vanilla Storyline -
User avatar
Renew
Senior Sergeant
Senior Sergeant
 

Re: lua & xml

by Doofoos » Sun Jan 03, 2016 4:32 pm

Renew wrote:i had another version without all these things :P

So your version of CustomNameplates is more perfomance friendly? Can you share it please? :)
Doofhoof - Tauren Druid - <KGB>
User avatar
Doofoos
Sergeant Major
Sergeant Major
 

Re: lua & xml

by Renew » Sun Jan 03, 2016 4:35 pm

Doofoos wrote:
Renew wrote:i had another version without all these things :P

So your version of CustomNameplates is more perfomance friendly? Can you share it please? :)


i dont use it - but the version is from here: http://www.wow-one.com/forum/topic/3089 ... ate-addon/
my Addons:
- Vanilla Healing Assignments - /viewtopic.php?f=63&t=23326
- Vanilla Storyline -
User avatar
Renew
Senior Sergeant
Senior Sergeant
 

Re: lua & xml

by Doofoos » Sun Jan 03, 2016 5:36 pm

Renew wrote:i dont use it - but the version is from here: http://www.wow-one.com/forum/topic/3089 ... ate-addon/

Im using version from Lulleh post in this topic, and it does consume a lot of memory, and i think my fps drops in crowded places like Suppression Room is connected with it :? (im using not clickable frames fix, cuz its impossible to move camera in crowded locations)
BTW i switched to sRaidFrames from Luna (can't handle luna's 40y range check anymore). and can't configure its buffs part - do you know if its possible to make rejuvenation and regrowth both be tracked, but not the gift of the wild\thorns, or make gift of the wild\thorns toggleable on keybind?
Doofhoof - Tauren Druid - <KGB>
User avatar
Doofoos
Sergeant Major
Sergeant Major
 

Re: lua & xml

by cyklon » Sun Jan 03, 2016 6:12 pm

If i want the save the position of the frame in "saved variables", do i need to save the position and send the value to a variable when i lock the position?
User avatar
cyklon
Senior Sergeant
Senior Sergeant
 

Re: lua & xml

by kuurtzen » Sun Jan 03, 2016 6:32 pm

I think frame's position get automatically saved either way you should check the saved variables page on wowwiki more info on that
kuurtzen
Senior Sergeant
Senior Sergeant
 

Re: lua & xml

by cyklon » Sun Jan 03, 2016 7:29 pm

I'm stuck again,, damn it..
This is the create frame row.. and as far as i understand it, the "nil" is the "name" of the frame (nil=there is no name)
Code: Select all
local f = CreateFrame("Frame", nil, UIParent)


So by doing this, the frame name should be refered as BoX right??
Code: Select all
local f = CreateFrame("Frame", BoX, UIParent)
User avatar
cyklon
Senior Sergeant
Senior Sergeant
 

Re: lua & xml

by modernist » Sun Jan 03, 2016 7:54 pm

you want the name saved as a string, so
Code: Select all
local f = CreateFrame("Frame", "BoX", UIParent)
modernist
Sergeant Major
Sergeant Major
 

Re: lua & xml

by cyklon » Tue Jan 05, 2016 12:35 pm

Ah, TNX!
User avatar
cyklon
Senior Sergeant
Senior Sergeant
 

Previous

Return to Addons & macros