modernist wrote:Renew wrote:modernist wrote:for example, CustomNameplates is a really good example of a major addon NOT doing this and the reason i would not recommend it to people based on the code i've looked through — if i remember correctly it creates a set of 8 new "buff" frames on every tick of its OnUpdate. assuming that you're running at a consistent 60fps, thats 28800 frames being created and stacked on top of one another inside of a minute.
i dont think you can create frames onupdate without getting massiv fps dropdown...also there is only 1 event frame in whole CustomNameplates addon...
https://github.com/jejkas/CustomNamepla ... es.lua#L87
https://github.com/jejkas/CustomNamepla ... s.lua#L151
looks like there's checks before creation initialises on any textures (and it uses CreateTexture parented to the plate itself rather than more frames), so i retract my complaint. maybe i was looking at a bootleg version previously.
i had another version without all these things