[Addon] Auctionator-Vanilla bugfixes and extensions

[Addon] Auctionator-Vanilla bugfixes and extensions

by Bit » Mon Sep 07, 2015 2:55 am

thread outdated - look here: viewtopic.php?f=63&t=21102
Last edited by Bit on Fri Sep 18, 2015 12:03 am, edited 7 times in total.
Bit
Sergeant Major
Sergeant Major
 

Re: [Addon] Auctionator-Vanilla bugfixes and extensions

by Zwox » Mon Sep 07, 2015 12:34 pm

I like the Refresh Button. Good work.
Zwox
Grunt
Grunt
 

Re: [Addon] Auctionator-Vanilla bugfixes and extensions

by zerf » Mon Sep 07, 2015 1:33 pm

Bit wrote:Initially I'd also planned to add a search mode that loads all pages at once and sorts by buyout and a feature to shiftclick an item to add its name to the searchbox, but I'm afraid they may both be impossible with the Vanilla API? The search could be implemented of course for displaying only but I don't think there's a reliable way to then get the right auction from a selection to actually buy.


That Shift + click thing is already implemented in addon called AuctionLink (http://addons.us.to/addon/auctionlink). I could add Auctionator support there, so you don't have to reimplement support for many inventory management systems.

Regarding auction id, you're right, 1.12 api doesn't have one. However, you don't need one - it doesn't matter if you buy first auction or last auction, as long as stack count, sell price and seller match (auctioneer generates ID in similar fashion)

PS: great work on addon, I was getting shivers of original spagetti code while fixing UI :)
vanilla wow addon collection - http://addons.us.to
User avatar
zerf
Senior Sergeant
Senior Sergeant
 

Re: [Addon] Auctionator-Vanilla bugfixes and extensions

by Bit » Mon Sep 07, 2015 1:50 pm

Thanks, gonna check out the shift click addon asap, if it doesn't require major hacks I might aswell just reimplement it. Curious how you did it though, found absolutely nothing in the api.

As for the ID thing, wouldn't the index be off after a "long" search of several pages in most cases?

I've improved the ui scale to look more like your version and about to try and make the entries adapt their size to the scroll bar (don't know if you've done that).

Also I'm about to add a rightclick instant-buyout feature (optional, default off).
Bit
Sergeant Major
Sergeant Major
 

Re: [Addon] Auctionator-Vanilla bugfixes and extensions

by Zwox » Mon Sep 07, 2015 2:08 pm

The Alt + Click works for me on this version ;)

BUT the UI is a little bit buggy on this version^^

-> http://i.imgur.com/HI3eqWW.jpg
Zwox
Grunt
Grunt
 

Re: [Addon] Auctionator-Vanilla bugfixes and extensions

by Bit » Mon Sep 07, 2015 2:15 pm

Zwox wrote:The Alt + Click works for me on this version ;)

BUT the UI is a little bit buggy on this version^^

-> http://i.imgur.com/HI3eqWW.jpg


Hm, it looks fine for me. Do you use a non default ui-scale? Or a resolution other than 1920x1080?
Gonna have to look into how to make it scale properly with those settings.
Bit
Sergeant Major
Sergeant Major
 

Re: [Addon] Auctionator-Vanilla bugfixes and extensions

by Zwox » Mon Sep 07, 2015 2:21 pm

normaly 1920x1080

this character has no addons exepct titan panel and the auction addons ;)
Zwox
Grunt
Grunt
 

Re: [Addon] Auctionator-Vanilla bugfixes and extensions

by zerf » Mon Sep 07, 2015 2:22 pm

It's not my addon, I just added missing support for inventory addon I was using. It hooks into inventory functions, that's why each inventory addon has to be implemented there (and reimplementing all of them in another addon is a waste imo).

Regarding ID - you search once and display result to user. User chooses one auction, clicks buy and you do another search with given values (name, price, stack size, seller). If you find a match, you buy it, if not - display an error message. If there are few results, second search ofc is not needed.

Anyway, the biggest benefit of buy tab imo was not grouping, but having a column that shows price of individual items in a stack (easier to compare). Later auctioneer versions have similar functionality, only in different way - it shows % of market value, so you can easily find cheapest auction in a long list.

My proposal is to either add similar thing into default UI (like later auctioneer versions did it) or add Buy tab and reimplement item search/buy there. I originally chose second option, because default UI is somewhat crammed, not a lot of space there. Plus, doing it in another tab has other benefits - you can implement extra features like a list of recent searches and support for random suffix items (so you can search items like "of the Frozen Wrath").
vanilla wow addon collection - http://addons.us.to
User avatar
zerf
Senior Sergeant
Senior Sergeant
 

Re: [Addon] Auctionator-Vanilla bugfixes and extensions

by Bit » Mon Sep 07, 2015 2:54 pm

Small update: added an instant buyout with right-click feature for the Browse tab (Default off, option in the settings), refactored options stuff into a separate lua file and removed the strange, pointless boolean-number conversions for the settings.

Zwox wrote:normaly 1920x1080

this character has no addons exepct titan panel and the auction addons ;)


Are you sure you don't have "use ui scale" checked in the graphics options? Well anyway, it should work with that too, gonna look into that next.
Bit
Sergeant Major
Sergeant Major
 

Next

Return to Addons & macros