[Addon] Auctionator-Vanilla bugfixes and extensions

[Bit]

Regarding ID - you search once and display result to user. User chooses one auction, clicks buy and you do another search with given values (name, price, stack size, seller). If you find a match, you buy it, if not - display an error message. If there are few results, second search ofc is not needed.

Hm, but there are rarely few results on nost, are there
This would be rather clumsy if you wanna buy Runecloth with 20 pages.

Anyway, the biggest benefit of buy tab imo was not grouping, but having a column that shows price of individual items in a stack (easier to compare). Later auctioneer versions have similar functionality, only in different way - it shows % of market value, so you can easily find cheapest auction in a long list.

Well but they're linked in a way. What you described above is a workaround for a multiple-pages search and sorting by price per unit isn't very interesting if you have data from one page only.

My proposal is to either add similar thing into default UI (like later auctioneer versions did it) or add Buy tab and reimplement item search/buy there. I originally chose second option, because default UI is somewhat crammed, not a lot of space there. Plus, doing it in another tab has other benefits - you can implement extra features like a list of recent searches and support for random suffix items (so you can search items like "of the Frozen Wrath").

The vanilla auctioneer doesn't do anything like this? Haven't used it in a while. I definitely agree it should be in a separate tab as you need to be able to opt out if it gets too clumsy (e.g., searching something with 100 pages) and it seems too drastic a change for a toggle option.

[Zwox]

Are you sure you don't have "use ui scale" checked in the graphics options? Well anyway, it should work with that too, gonna look into that next.

Y checked it and its true... but its bullshit than cause the moste of the ppl use ui scale cause all is rly big

[Bit]

Are you sure you don't have "use ui scale" checked in the graphics options? Well anyway, it should work with that too, gonna look into that next.

Y checked it and its true... but its bullshit than cause the moste of the ppl use ui scale cause all is rly big

Well, many people use stuff like bongos that completely replaces the hideous blizzard stuff anyway - but I agree it needs fixing in any case.

[zerf]

The vanilla auctioneer doesn't do anything like this? Haven't used it in a while. I definitely agree it should be in a separate tab as you need to be able to opt out if it gets too clumsy (e.g., searching something with 100 pages) and it seems too drastic a change for a toggle option.

Nope. What do you use then for searching cheapest prices? Default sort function is useless when you have different stack sizes.

Regarding that scaling problem, anchor to corner (topleft), not left (since it changes when you start scaling UI).
I did it this way:

Code: Select all

+   local frame = CreateFrame("Frame", "Auctionator_Sell_Panel", AuctionFrame, "Auctionator_Sell_Template");
+   frame:SetParent("AuctionFrame");
+   frame:SetPoint("TOPLEFT", "AuctionFrame", "TOPLEFT", 210, 0);
+   relevel(frame);
+   frame:Hide();

[Greengrass]

Thank you very much!

[Bit]

Nope. What do you use then for searching cheapest prices? Default sort function is useless when you have different stack sizes.

I've just been using the regular search but yeah, it's quite useless.

Regarding that scaling problem [...]

Oh, I stupidly thought I could simplify it by using top as an anchor, making it easier to align everything vertically. Will update it this evening. Thanks! (I hate xml )


I've rewritten the multiple page query used for the auctionator tab in a general way so it could be reused for the Browse stuff. (takes a table with the search settings and two callbacks, oncomplete (gets the data) and onabort, would have to add a third one I guess, onFind or something, for the second search (the one to find the auction the user has chosen to buy)

[Bit]

Update: fixed the scaling issue
Here's what it looks like now:

Edit: The entries now shrink appropriately when there's a scroll bar

[Zwox]

/cheers and now the Buy Tab

[mattk926]

Bravo!

I was wondering how this has taken this long for someone to fix these issues as the stock blizzard auction UI is crap.

Thank you both for your work on this and I hope it continues. I really miss the buy tab.

Keep up the great work!

[Coreborn]

Would it be possible to move the options button into the main frame of auctionator, maybe next to the refresh button inside the tab? Its the only reason im not using this version. Because the options button overlapping other auctionhouse addons i use like AuctionFilterPlus, or maybe give an option to remove the button from the toc file without getting lua errors, since its in general not of much use when set.