Damagemeter with segments for bossfights?

Re: Damagemeter with segments for bossfights?

by Geigerkind » Sat Jan 09, 2016 6:46 pm

This way point procs will be displayed:

Image
My Addons:
DPSMate - A combat analyzation tool (/viewtopic.php?f=63&t=38042)
Vanilla Consolidated Buff-Frames (/viewtopic.php?f=63&t=18189)
Modified Power Auras (/viewtopic.php?f=63&t=18251)
User avatar
Geigerkind
Senior Sergeant
Senior Sergeant
 

Re: Damagemeter with segments for bossfights?

by schaka » Sat Jan 09, 2016 7:16 pm

Geigerkind wrote:Not possible they said...
Vanilla API does not support that they said...
Image


Tracking interrupts? I thought LunaUF already does that.
It works sort of the same way you can track PvP trinket (in TBC anyway) by just analyzing the combatlog in a smart way, correct?

What I did in TBC was just track all events and see if anything broke the CC before the timer ran out, based on timestamp. I guess you track whether a cast is currently going on and then if any spell is casted that could interrupt it (stun, CC, interrupt, any other spell by the caster etc)?
schaka
Senior Sergeant
Senior Sergeant
 

Re: Damagemeter with segments for bossfights?

by Dilatazu » Sat Jan 09, 2016 8:29 pm

Geigerkind wrote:Not possible they said...
Vanilla API does not support that they said...
Image


Amazing work you are doing Geigerkind!
This only tracks if the interrupt actually interrupted something right?

If you are able to get tracking dispells working properly it would be even more amazing!
But do not get hung up on tracking dispells, i tried to get tracking it working reliably for some time and had to give up eventually.

Either way, take ur time with this project and maybe it can be good enough to get rid of SW_Stats for good. I would gladly help make the raidstats addon grab data from this instead of SW_Stats. Might be possible to even add the extra data such as interrupts etc on RaidStats website :)
Dilatazu
Private
Private
 

Re: Damagemeter with segments for bossfights?

by Geigerkind » Sat Jan 09, 2016 10:01 pm

@Schaka
Correct. With the addition to verify if the spell is actually interrupted.
Btw. I tried using your spell DB but it is a bit too huge, which causes a little lag. Is there a version with class and boss spells only? I may use it incorrectly as well.

@Dillatazu
It already does track the dispells correctly. You can see what is from whom by whom dispelled. It depends on Addon communication though to track by whom correctly for dispells like abolish poison. For direct dispells it works fine.

Edit: Yes, it tracks it only if it is sure you interrupted something. That is why the interrupts take 5 seconds before they are shown on the meter.
My Addons:
DPSMate - A combat analyzation tool (/viewtopic.php?f=63&t=38042)
Vanilla Consolidated Buff-Frames (/viewtopic.php?f=63&t=18189)
Modified Power Auras (/viewtopic.php?f=63&t=18251)
User avatar
Geigerkind
Senior Sergeant
Senior Sergeant
 

Re: Damagemeter with segments for bossfights?

by Dilatazu » Sat Jan 09, 2016 10:42 pm

Geigerkind wrote:@Dillatazu
It already does track the dispells correctly. You can see what is from whom by whom dispelled. It depends on Addon communication though to track by whom correctly for dispells like abolish poison. For direct dispells it works fine.


That sounds awesome if it is true!
When i tried to get it working myself(almost 3 years ago on ED realm) i had it working perfect several times i thought. After having other players test it i discovered that it added multiple dispells and sometimes none depending on how the player was dispelling. For example:
1. mouseover dispelling
2. decurse
3. other decurse addon
4. manually target and dispelling

Getting it to work for all those cases and not have duplicate detected sometimes was seemingly impossible for me. But maybe it was just the technique i used that i was not able to get reliable enough.
The hardest part was the combination with if you cancel the dispell(lag problem), spamming dispell or if the dispell failed making sure it did not get tracked when it shouldnt.

Anyways, goodluck with the continued development and please contact me when you are "done" :).
Dilatazu
Private
Private
 

Re: Damagemeter with segments for bossfights?

by Geigerkind » Sat Jan 09, 2016 11:03 pm

Sure, Im looking forward to it :>
My Addons:
DPSMate - A combat analyzation tool (/viewtopic.php?f=63&t=38042)
Vanilla Consolidated Buff-Frames (/viewtopic.php?f=63&t=18189)
Modified Power Auras (/viewtopic.php?f=63&t=18251)
User avatar
Geigerkind
Senior Sergeant
Senior Sergeant
 

Re: Damagemeter with segments for bossfights?

by schaka » Sun Jan 10, 2016 11:43 am

Geigerkind wrote:@Schaka
Correct. With the addition to verify if the spell is actually interrupted.
Btw. I tried using your spell DB but it is a bit too huge, which causes a little lag. Is there a version with class and boss spells only? I may use it incorrectly as well.


So the way you do it is by checking whether the caster cast another spell of the same school within the next 5, 6 or 8 seconds (physical, spell lock, counter spell)? That's pretty smart, actually.

As for my spell DB, it's almost exclusively key - value lookup. Execpt sometimes you get a whole table returned with about 5 results. I don't have a version with just class spells, unfortunately. But I guess you could look into how MSBT (by Athene) does it? He must have all the important class spells.

Edit: I just realized lookup by name and icon iterate through the entire table (which is like 30000 entries). I guess it would make sense to cause some data redundancy and make sure you have smaller lookup tables for spell by name using key-value as well.

But the best quick fix would be to just cache the tables that are returned by GetSpellInfoVanilla. Like, say you search for <name>, a and the result is a table with 3 entries, you just cache that table and make GetSpellInfoVanilla (or your own lookup function) check the cache before doing the slow iteration. That way you have one slow lookup per session (or only once, if you keep the cache in SavedVariables). If you should make this an addition to my DB, you're welcome to do a pull request :)
schaka
Senior Sergeant
Senior Sergeant
 

Re: Damagemeter with segments for bossfights?

by Athene » Sun Jan 10, 2016 12:18 pm

But I guess you could look into how MSBT (by Athene) does it? He must have all the important class spells.


I use Babble-Spell-2.2 as my spell DB, it has all the class spells + talents + translation in many languages (must have) and I added some direct damage spells in the addon (here at the begining: https://github.com/AtheneGenesis/Vanill ... leText.lua), I added only direct damage because when I get a debuff the addon associate the icon to the name of the debuff and keep it in a table for the current session to save loading times.

@Schaka: I just made a pull request for GetSpellInfoVanilla, I was able to reduce file size by 25% it should help with the initial load times ;)
<Genesis>
youtube.com/GenesisGuilde

MSBT [Continued] landed on Nostalrius, check it here: forum.nostalrius.org/viewtopic.php?f=63&t=1721
User avatar
Athene
Senior Sergeant
Senior Sergeant
 

Re: Damagemeter with segments for bossfights?

by Noxx » Tue Jan 12, 2016 10:28 am

Give a proper Damagemeter plox
Image
User avatar
Noxx
Sergeant Major
Sergeant Major
 

Re: Damagemeter with segments for bossfights?

by kiddcabbage » Tue Jan 19, 2016 7:37 am

Just wanted to come in and say that I can't freaking wait for DPSMate. Been waiting so long for something better than SWStats in this version.
kiddcabbage
Tester
 

PreviousNext

Return to Addons & macros