[Addon] LunaUnitFrames

[Rhena]

Medlindes: The color of the pets healthbar shows its happines.

imjust0ne: I don't support clique. Luna has its own click casting and i don't want to maintain another addon.

slipry: I don't support modding the addon in any way because you do it on your own risk of it completly breaking. But as a hint: There is a adjustbars function for every frame except raid that sets up the bars. There should be a one pixel gap defined between each bar.

And uh the backdrop... Its still the code of when i started writing this. I don't even know if its streamöined across all frames yet. It should always be a more transparent version of the original bar i guess. If its not it need rework

@everyone with performance issues:
I am afraid i need a lot more information to nail this problem down since my NASA mainframe (computer) doesn't show any issues at all.
Things that could help me:
- At what performance level would you describe your pc
- How many buffs are you tracking?
-Where were you (AV, instance, raid etc) or is it generally
-What was the last working version of LUF?
-Anything else you can think of that might help

[Renew]

imjust0ne: I don't support clique. Luna has its own click casting and i don't want to maintain another addon.

clique support is a oneliner -_-
clique is a common healer addon from 2006:/

your function

Code: Select all

Luna_OnClick()

just needs

Code: Select all

if Clique then Clique:OnClick(arg1, this.unit)

argues are button as string and unitID as string..

edit: i love your work man, keep it up!

[slipry]

slipry: I don't support modding the addon in any way because you do it on your own risk of it completly breaking. But as a hint: There is a adjustbars function for every frame except raid that sets up the bars. There should be a one pixel gap defined between each bar.

editting the gaps only greats a space at the bottom of the stack not between power/health

[Esselenwiel]

This addon is <3 Thank you.

Just a thing I have noticed is that I use TinyTip to anchor the tooltip to the mouse; and when I mouse over the frames in combat it displays the tooltip about right click interaction with the frame. Would it be possible to add an option to disable tooltips over frames when in combat?

This only happens when in combat and targeting a party member, if I target a mob no tooltip is shown. Here is what I'm talking about: http://i.imgur.com/9M0LC3J.jpg as you can see it's really annoying as a healer.

[kutsal]

I am sorry if I am not to detailed about it but I got the freezes and stutter at Nefarian fight when all the skeletons spawned at 20%. And I think the last working version was either 1080 or 1081. I don't know if it is possible to download these for the time beeing? I rather have an older version that doesn't have the current issue when raiding. I will see if I can make a post that is more in depth than it is now.

[SaltySlug]

@everyone with performance issues:
I am afraid i need a lot more information to nail this problem down since my NASA mainframe (computer) doesn't show any issues at all.
Things that could help me:
- At what performance level would you describe your pc
- How many buffs are you tracking?
-Where were you (AV, instance, raid etc) or is it generally
-What was the last working version of LUF?
-Anything else you can think of that might help

-My PC specs are:

It can handle most modern games without issue.

-Tracking 0 buffs
-Inside AV
-Not sure on last working version because I only just started using the raid frames for AV

With raid frames disabled I get no stutter issues. Also addon memory usage stays low and only needs to garbage collect every 10-15min or so.


When I enable the raid frames the memory usage jumps up and has to force a garbage collection about every 10seconds, causing a screen stutter every 10sec or so.


Also noticing a stutter whenever someone joins/leaves AV and it has to draw a new bar for them.
It might be happening when people get debuffs also but I haven't tested it thoroughly.

If you need any other information let me know.

[Ptahmose]

Rhena,

In previous builds of LUF you could set the raid frames to load up/down/right/left. This seems gone now, or am I missing something?

[kutsal]

@everyone with performance issues:
I am afraid i need a lot more information to nail this problem down since my NASA mainframe (computer) doesn't show any issues at all.
Things that could help me:
- At what performance level would you describe your pc
- How many buffs are you tracking?
-Where were you (AV, instance, raid etc) or is it generally
-What was the last working version of LUF?
-Anything else you can think of that might help

Continuing my post to be more detailed.

My pc specs:


Tracking 0 buffs
I do not notice stutter or w/e when I am solo, I noticed the performance issues last BWL raid I did with my guild.
Last working was 1081/1080 I believe but honestly have no idea if I did raid with these versions the week before where I had no issue. I usually check this thread everyday and update it asap when I see a newer version.

I noticed stutters at Razorgore fights, It happened the whole phase 1 of the fight where there were mobs in the area.

And the worst I noticed was at 20% Nefarian fight when all the dead mobs turn into skeletons. I had a freeze of 2-3 seconds and a bit of stutter as well.

Is this perhaps related to my raid targetting all different mobs or w/e? Or maybe the aggro check? I did not know it was related to LUF before and it was sudden issue so I could not really test with it in a raid environment. I will try to the next raid and see if I can catch something out of the ordinary.

[imjust0ne]

imjust0ne: I don't support clique. Luna has its own click casting and i don't want to maintain another addon.

clique support is a oneliner -_-
clique is a common healer addon from 2006:/

your function

Code: Select all

Luna_OnClick()

just needs

Code: Select all

if Clique then Clique:OnClick(arg1, this.unit)

argues are button as string and unitID as string..

edit: i love your work man, keep it up!

Hey Renew thanks so much for the help....

To be be more specific for the less tech savy out there I had to add the following to your raid.lua file within luna

if Clique then Clique:OnClick(arg1, this.unit) end


It needs to be added under the function pasted below:

local function Luna_Raid_OnClick()
local button, modifier
if arg1 == "LeftButton" then
button = 1
elseif arg1 == "RightButton" then
button = 2
elseif arg1 == "MiddleButton" then
button = 3
elseif arg1 == "Button4" then
button = 4
else
button = 5
end

You can use notepad++ to do this change

I really hope that this (one line of code) support gets built into Luna, as clique is awesome and works (with this change) flawlessly with luna. Yes Luna has some built in click casting support, but some of really love Clique...please support us!

[Renew]

actually i wouldnt do it like that, but integrate that line into the IF- statements there are already exist, so you can make sure there will be no other action after clique ;D

as i said, its a oneliner (same as classic mouseover) to integrate into luna unitframe