[Addon] Questie *v2.66* - A quest helper for vanilla!

Re: [Addon] Questie *v2.62* - A quest helper for vanilla!

by Dyaxler » Tue Mar 22, 2016 6:22 pm

@Smokeit - 2.3 --> 2.6 just has a lot of bug fixes and some new features. Available quests weren't changed so you're not missing out on any "game content".

Petroix wrote:Nice, I had hope it would fix most problems and indeed ESC button works now all the time. But I don't know why, this 2.62 version removed fullscreen from cartographer map, I can't put it on fullscreen anymore. Did you change anything related to it? After /rl it shows I'm somewhere else on the map on different continent. If I disable Questie it works again, these two addons definetly have to be in conflict.

Image

Does it tell you anything?


I f'ing HATE LUA! This line of code is present:

Code: Select all
if (not IsAddOnLoaded("Cartographer")) or (not IsAddOnLoaded("MetaMap")) then


Cartographer is loaded so it should skip that entire map modification block but for some reason it's not. Then I remembered that Cartographer is a modular ACE addon so "Look N Feel" (which controls the Worldmap) is sort of outside the "Cartographer" addon. So now if it see's the offending module it returns to end.

Code: Select all
if Cartographer:IsModule(Cartographer_LookNFeel) then return end


I also had to add Cartographer as an Optional Addon dependency just so I could access it's namespace. There is a way to do it without having to declare it as an optional addon but it would mean that Cartographer needed to load first before Questie. As an optional dependency, if the addon is present, Questie waits for it's functions to be declared before it begins running it's own checks avoiding a bunch of nil errors.

I also cleaned up the Map Mod code and removed some redundant lines that might have been conflicting with certain elements/functions... such as the PVP map.

Fix will be in the next release.
Author of SpartanUI for Vanilla WoW 1.12
More info available here: Nostalrius Forum thread link. - Feed back welcome.
Submit bugs on GitHub or post about it in the forum thread.
User avatar
Dyaxler
Senior Sergeant
Senior Sergeant
 

Re: [Addon] Questie *v2.62* - A quest helper for vanilla!

by Dyaxler » Tue Mar 22, 2016 6:24 pm

sam51 wrote:Hello i'have a problem i'have not the minimap button questie and the quests tracker doesnt appear and when i try to track a quest this come:

Image



Please use
Code: Select all
/questie clearconfig
and try again.

The error is that it's looking for a setting in your SavedVariables that isn't present. The above command will rebuild your SavedVariables. This will not clear your finished Quests.
Author of SpartanUI for Vanilla WoW 1.12
More info available here: Nostalrius Forum thread link. - Feed back welcome.
Submit bugs on GitHub or post about it in the forum thread.
User avatar
Dyaxler
Senior Sergeant
Senior Sergeant
 

Re: [Addon] Questie *v2.62* - A quest helper for vanilla!

by Dyaxler » Tue Mar 22, 2016 6:27 pm

cyklon wrote:When in bg, toggle map without addon just show world. Also minibgmap not showing players.


Which addon are you referencing? Are you saying that without Cartographer loaded and with Questie loaded all you see is the Worldmap instead of the BG map? Can you be more specific when describing your issue. :)
Author of SpartanUI for Vanilla WoW 1.12
More info available here: Nostalrius Forum thread link. - Feed back welcome.
Submit bugs on GitHub or post about it in the forum thread.
User avatar
Dyaxler
Senior Sergeant
Senior Sergeant
 

Re: [Addon] Questie *v2.62* - A quest helper for vanilla!

by Dyaxler » Tue Mar 22, 2016 6:45 pm

On a side note... I'm working on re-structuring how quests are cached for the purpose of Tracking vs Untracking and updating quests. I failed to realize that if you untrack a quest it wipes the cached quest progress so unless you are actively tracking the quest, you might not get map updates. For example, if you aren't tracking a quest and your killing a mob for the untracked quest and obtain all the needed items for a specific monster... the icons on the worldmap won't disappear until you re-track that quest. It doesn't' matter if you have the option "alwaysshow" quests or not, enabled.

The new version will ALWAYS cache the quest if it's in your QuestLog and simple flag or unflag a database entry if it's on the QuestTracker or not. This will solve both map tracking issues and reduce the overhead of getting quest data when tracking or UN-tracking quests. Additionally, the functions to populate the tracker won't keep trying to get updated quest data until an update actually occurs. It was an "all or nothing" kind of approach which from an execution standpoint was fairly expensive. Might also resolve some FPS drops people were experiencing.
Author of SpartanUI for Vanilla WoW 1.12
More info available here: Nostalrius Forum thread link. - Feed back welcome.
Submit bugs on GitHub or post about it in the forum thread.
User avatar
Dyaxler
Senior Sergeant
Senior Sergeant
 

Re: [Addon] Questie *v2.62* - A quest helper for vanilla!

by Petroix » Tue Mar 22, 2016 6:54 pm

It's very comforting that someone actually can work on it and fix/improve some things, I really appreciate what you do :) About Cartographer it has its issues too but with fullscreen (looknfeel active) it works somehow. Along with Questie (but prior version) there was only ESC button problem. With Questie v2.62, ESC is finally working but cartographer fullscreen world map is broken. I'll stay at v2.61 for now, hope you will be able to fix that too ;)
Petroix
Senior Sergeant
Senior Sergeant
 

Re: [Addon] Questie *v2.62* - A quest helper for vanilla!

by cyklon » Tue Mar 22, 2016 6:57 pm

Dyaxler wrote:
cyklon wrote:When in bg, toggle map without addon just show world. Also minibgmap not showing players.


Which addon are you referencing? Are you saying that without Cartographer loaded and with Questie loaded all you see is the Worldmap instead of the BG map? Can you be more specific when describing your issue. :)

I think the minibgmap is from fubar addon, can't give you the name as I am at work atm.
I don't have a mapaddon for "normal" map.
Shem I enter a bg and show the map it displays the maximum zoomed out world instead of the bg map.

Hope this helps
User avatar
cyklon
Senior Sergeant
Senior Sergeant
 

Re: [Addon] Questie *v2.62* - A quest helper for vanilla!

by andrebosis » Tue Mar 22, 2016 7:46 pm

Did you get my email with the files you requested?
andrebosis
Tester
 

Re: [Addon] Questie *v2.62* - A quest helper for vanilla!

by Dyaxler » Tue Mar 22, 2016 9:54 pm

Hmmm... interesting about the BG map issue. Cartographer has it's own system. I tried looking for a "minibgmap" addon but didn't see anything that jumped out. FuBar or otherwise. Can someone provide a link to the addon?

In the meantime I wrote a better method for detecting Cartographer. Seems that... "if (not Cartographer)" doesn't really work in all situations however "if (Cartographer)" works in all situations even it's sub-components. So here is the new method...

Code: Select all
if (IsAddOnLoaded("Cartographer")) or (IsAddOnLoaded("MetaMap")) then
      return
   elseif (not IsAddOnLoaded("Cartographer")) or (not IsAddOnLoaded("MetaMap")) then


So if Cartographer or MetaMap is loaded and active... it returns and skips the Map Mod code. Else... if it doesn't exists and only if it doesn't exists then it runs the Map Mod code.

I was able to use ALL Cartographer functions with no errors and safely Mod the default Blizzard Worldmap when Cartographer isn't enabled. Now back to finishing my testing on the new QuestCache code.
Author of SpartanUI for Vanilla WoW 1.12
More info available here: Nostalrius Forum thread link. - Feed back welcome.
Submit bugs on GitHub or post about it in the forum thread.
User avatar
Dyaxler
Senior Sergeant
Senior Sergeant
 

Re: [Addon] Questie *v2.62* - A quest helper for vanilla!

by Dyaxler » Tue Mar 22, 2016 9:58 pm

andrebosis wrote:Did you get my email with the files you requested?


Might be you... might not be but I'm chatting with someone over email right now. :D
Author of SpartanUI for Vanilla WoW 1.12
More info available here: Nostalrius Forum thread link. - Feed back welcome.
Submit bugs on GitHub or post about it in the forum thread.
User avatar
Dyaxler
Senior Sergeant
Senior Sergeant
 

Re: [Addon] Questie *v2.62* - A quest helper for vanilla!

by cyklon » Wed Mar 23, 2016 12:05 am

Dyaxler wrote:Hmmm... interesting about the BG map issue. Cartographer has it's own system. I tried looking for a "minibgmap" addon but didn't see anything that jumped out. FuBar or otherwise. Can someone provide a link to the addon?

In the meantime I wrote a better method for detecting Cartographer. Seems that... "if (not Cartographer)" doesn't really work in all situations however "if (Cartographer)" works in all situations even it's sub-components. So here is the new method...

Code: Select all
if (IsAddOnLoaded("Cartographer")) or (IsAddOnLoaded("MetaMap")) then
      return
   elseif (not IsAddOnLoaded("Cartographer")) or (not IsAddOnLoaded("MetaMap")) then


So if Cartographer or MetaMap is loaded and active... it returns and skips the Map Mod code. Else... if it doesn't exists and only if it doesn't exists then it runs the Map Mod code.

I was able to use ALL Cartographer functions with no errors and safely Mod the default Blizzard Worldmap when Cartographer isn't enabled. Now back to finishing my testing on the new QuestCache code.


Finally some testing done with the latest update.. Did /questie reset thingy

Issues Full UI loaded
HonorFU addon loads a minibattlemap in BG's, in 2,61 players are visible, 2,62 not. Open map in BG shows max zoomed out world, not the current BG.

LoadIT + Questie loaded
pessing M for map opens map but cant close it with M, must use ESC.
O button not working even tho its keybinded. other buttons not tested.
Can't target my player frame, self that is.
Toggle button just hide questie for a second or so, after that its returned.
User avatar
cyklon
Senior Sergeant
Senior Sergeant
 

PreviousNext

Return to Addons & macros