Need help making "Job's done!" addon work with Vanilla

[Kaiji]

So I was thinking how much I miss the "Job's done!" sound that a lot of questing addons fired when you completed a quest and after looking I found this recent addon for retail that does just that.

The code looks very simple but I have no idea how to get it working with Vanilla.

Does anyone know what the correct code would be to make it work in 1.12?

[Roadblock]

I whipped something up but didn't have time to properly test.
If you feel like playing the guinea pig ... (for science!)

QuestSoundBits
viewtopic.php?f=63&t=35180

Take it for a spin, if it works, report back and I'll give it its own thread

[Kaiji]

Completed a quest objective and heard "Ready to work!".

Thanks a million for doing this.

[Kaiji]

Hmmm... I'd only tried it on one quest to test the addon (did a bunch of dungeons yesterday) but I've been properly questing today and it only worked the first time an objective was met. :\

[Kaiji]

Another observation. It says "Ready to work!" when an individual objective is completed, but it also says "Ready to work!" when a full quest is completed, instead of "Job's done!". I notice there's a "Job's done" MP3 in the folder but I never hear it.

Loving the addon so far though.

[Roadblock]

I would prefer it if you post comments or bugs on the addon thread since it has one now.

Are you using the latest version?
1. I derped when I pushed the fix for the throttle bug and left the objective progress flag to true (I was using it to get more alerts for testing)
You can open QuestSoundBits.lua in a text editor and change

Code: Select all

["Progress"] = true,

to

Code: Select all

["Progress"] = false,

at the top of the file.
It will make it less spammy.
2. I've noticed that several quests do not give info messages (the yellow text up top) for progress or completion.
That looks like a bug in the client; addon relies on those firing (doesn't matter if another addon is hiding them) for its alerts.

That's something I can't fix unfortunately.
If you have noticed completion messages without sound report it to the addon thread and I'll take another look.