Questie Improved - A little...

[Dyaxler]

Hey all,

I have another gift for the community. First and foremost I'm not at all interested in taking this project on full time. I only made some very useful improvements to the latest stable version: v2.0.12. I've uploaded my changes to GitHub so you can clearly see the difference between v2.0.12 and my new release that I've tagged v2.0.14 (they used the tag v2.0.13 for their unstable "dev" version.)

This new version has better tool tips that shows the quest level and the quest starter and/or finisher. I've also added the ability to Shift+CTRL Click on a quest icon to manually complete it. This is the same function that the slash cmd uses /questie complete "insert quest name here". If there is more than one step to complete a dialog popup will appear that will accept the step number you'd like to flag as complete. I've also added a refresh routine into the click function to refresh the WorldMap after each click. The icons will immediately disappear without a ReloadUI or Questie Toggle from the WorldMap. I have personally wiped my local Questie SavedVariables file in order to test these changes and I was able to complete all the quests that I've done so far on my level 31 Priest without issue. It only took me 5 min. Imagine how long it would have taken me if I were to manually type hundreds of quests via the command line with /questie complete?

*UPDATE* - I've removed my modified version and forked v2.0.13 from the master branch. I've submitted a pull request on GitHub to have my changes merged with theirs.

viewtopic.php?f=63&t=36859&start=10#p258965

/cheers
Dyaxler

[espera542180]

Nvm guys, I solved it! You have to rename "Questie-2.0.14" folder to "Questie" and it will show in yer AddOns menu.

[schaka]

If you make a pull request, I will merge your changes into our master branch. However, any future modifications would probably be best in the 3.0 branch, as before we stopped developing that's where all the time went.

[Velkow]

Nice job, you saved my life

[Dyaxler]

Ah. I read a post saying you guys quit so I didn't bother to make a pull request. However, the function that I put into the 2.0 version is actually based on the one in the 3.0 version.

But I would be happy to merge my changes with yours if you'd like. That way I don't have to host a custom version. I felt kind of "dirty" doing it this way.

Hey, just curious but why is there a separate "mod" for the Compat stuff? Why not just include the LUA in the base TOC for Questie like I've done in my 2.0.14 version?

/cheers

[PEHO.HOL]

Just to understand this correctly..

If I update my Questie version - will it automaticly clear/remove all quests, I have already completed?

And will it do this, for all my characters seperately?

[Dyaxler]

It will not clear your quests. Those are stored in your SavedVariables and each character has their own. As long as you leave the files in your WTF directory alone. I didn't touch the code pertaining to how data is saved so another file won't be created. But, as a general practice I always back up my SavedVariables before upgrading just in case. Wouldn't hurt. They aren't very big files.

[Rimfrostr]

When I use this with QuestieCompatibility, from the 2.0.14 version, I can't get past the loading screen when trying to log in on any character. It works when I remove the QuestieCompatibility though. Will this have any impact?

[schaka]

Ah. I read a post saying you guys quit so I didn't bother to make a pull request. However, the function that I put into the 2.0 version is actually based on the one in the 3.0 version.

But I would be happy to merge my changes with yours if you'd like. That way I don't have to host a custom version. I felt kind of "dirty" doing it this way.

Hey, just curious but why is there a separate "mod" for the Compat stuff? Why not just include the LUA in the base TOC for Questie like I've done in my 2.0.14 version?

/cheers

I can give you access to the repository too, so you don't have to run your own, if you want. That way any changes you make go to the links that already rank high on Google and people won't be complaining (a lot).
The reason we had a separate addon running was mostly to avoid other addons messing everything up by hooking game functions and changing their return values to things different than what we expected. A LOT of people used addons that modified the quest name, for example. Addons are executed alphabetically, so that prefixing them with "!" ensures they are loaded first.

[Dyaxler]

Ahhh yes. I completely forgot about that nifty little trick. That makes perfect sense.

Sure. Granting access to the repository or just looking at my pull request is fine by me either way.